Gemini CLI PR fixes empty shell output sent to ACP clients
2SinceJuly · ghdev · 2026-10-26
PR #29958 on google-gemini/gemini-cli fixes ACP clients receiving an empty toolcallupdate for runshellcommand results.
- Root cause: shell.ts prefers the PTY AnsiOutput snapshot when non-empty, but toToolCallContent only handled string and file-diff returnDisplay values, returning null for AnsiOutput and sending content: [].
- Fix: AnsiOutput lines and tokens are now flattened to plain text, matching how the TUI (AnsiOutputText) and the a2a-server already render it; string and diff handling are unchanged, and empty AnsiOutput still returns null.
- Validation: A new unit test fails on main and passes with the change; all 114 tests in src/acp pass, plus typecheck, ESLint, and Prettier, verified in a Linux Docker container (node:22-bookworm, arm64).
More from coding & agent
- Dev builds open-source Excalidraw MCP after AI-generated diagrams kept overlapping text and arrows — pikahikmag · 2026-10-28
- DeepSeek vs Haiku pricing debunk: accounting for peak rates and token use, 1017 is 2-2.5x cheaper — teortaxesTex · 2026-10-28
- Viral screenshot shows an agent spawning 32 parallel workspaces in ~30 seconds — cephaloform · 2026-10-28
- Grok Bot 0.78.1 hides unreleased per-bot logins with manager-only team sharing — faraz0x · 2026-10-28
- Uber Built a Legal Redlining Agent for Its Lawyers—Here's What It Learned — AxSaucedo · 2026-10-28
- GraphRAG's hub-node trap: same two-hop Cypher costs 71 DB hits normally, 60,013 on a hub — JeremyCMorgan · 2026-10-28