Gemini CLI PR fixes checker env leak: third-party checkers once saw GEMINI_API_KEY
ManoharPaturi · ghdev · 2026-09-27
A PR against google-gemini/gemini-cli patches two flaws in CheckerRunner: external checker binaries inherited the full CLI process environment — including GEMINIAPIKEY and every other secret — and their stdout accumulated without a cap, so a buggy or malicious checker could exhaust memory before the timeout fired.
The fix:
- A new buildCheckerEnv gives external checkers a minimal allowlist (PATH, plus SYSTEMROOT on Windows) merged with explicit config.env entries, keeping legitimate checker config working while secrets stay out of reach.
- stdout/stderr are capped at 256KB each; on overflow the process is killed (SIGTERM with a 5s SIGKILL fallback) and the tool call is DENY-ed with a clear reason, failing closed by default.
- Class docs state the trust boundary: external checkers are third-party and untrusted until proven otherwise.
Tests included; checker-runner suite passes 12/12 with the fix.
More from coding & agent
- Baseten's Guide: Evaluate Open Models for Coding Agents on Your Own PRs — baseten · 2026-11-16
- Google Research open-sources PaperOrchestra, a multi-agent framework for writing AI papers — google-research · 2026-11-16
- ffmpeg-skill gives coding agents local video editing via 42 FFmpeg tools and MCP — kajisho5 · 2026-11-16
- Agents Now Reply to Slack Messages on Their Own, Resolving a Prod Incident Ghost-to-Ghost — iamrobotbear · 2026-11-16
- Engineer's Interview Prep Method: Use Claude to Find Which Answers Undersell Your AI Work — brandon_galang · 2026-11-16
- DeepSeek open-sources its app frontend "chat-demo", already at 3.9k stars — NielsRogge · 2026-11-16